Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont commuicate wrong flash premium #822

Merged
merged 3 commits into from
Mar 14, 2023
Merged

fix: dont commuicate wrong flash premium #822

merged 3 commits into from
Mar 14, 2023

Conversation

sakulstra
Copy link
Collaborator

  • fix: don't require flashloan premium when premium is zero
    • currently there are two cases in which flashloan premium is zero (being flashborrower & using mode != 0) - in the case of mode != 0, currently the receiver would receive flashLoanPremium != 0 which will not be required to return. With the applied fix the premium will be correctly passed as 0

@height
Copy link

height bot commented Mar 7, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@sakulstra sakulstra changed the title pick: cherry-pick fl fix from #820 fix: dont commuicate wrong flash premium Mar 7, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (94e571f) 99.65% compared to head (0105bd3) 99.65%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #822   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files          45       45           
  Lines        2300     2303    +3     
  Branches      421      423    +2     
=======================================
+ Hits         2292     2295    +3     
  Misses          8        8
Impacted Files Coverage Δ
...tracts/protocol/libraries/logic/FlashLoanLogic.sol 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sakulstra sakulstra changed the base branch from master to feat/3.0.2 March 10, 2023 15:21
@miguelmtzinf miguelmtzinf changed the base branch from feat/3.0.2-old to feat/3.0.2 March 13, 2023 14:14
@miguelmtzinf miguelmtzinf self-requested a review March 14, 2023 08:53
@miguelmtzinf miguelmtzinf merged commit 7b2a284 into aave:feat/3.0.2 Mar 14, 2023
@github-actions github-actions bot mentioned this pull request Jun 26, 2023
Merged
This was referenced Jun 14, 2024
Closed
Closed
Closed
@tobistudio tobistudio mentioned this pull request Jul 13, 2024
Closed
@tobistudio tobistudio mentioned this pull request Jul 23, 2024
Closed
This was referenced Jul 31, 2024
Closed
Closed
This was referenced Aug 6, 2024
Closed
Closed
This was referenced Aug 16, 2024
Closed
Closed
This was referenced Aug 24, 2024
Closed
Closed
This was referenced Sep 1, 2024
Closed
Closed
Closed
Closed
@tobistudio tobistudio mentioned this pull request Sep 10, 2024
Closed
This was referenced Sep 24, 2024
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelmtzinf miguelmtzinf miguelmtzinf approved these changes

@The-3D The-3D Awaiting requested review from The-3D The-3D is a code owner

@foodaka foodaka Awaiting requested review from foodaka foodaka is a code owner

@kartojal kartojal Awaiting requested review from kartojal

@Zer0dot Zer0dot Awaiting requested review from Zer0dot

@donosonaumczuk donosonaumczuk Awaiting requested review from donosonaumczuk

@eboadom eboadom Awaiting requested review from eboadom eboadom is a code owner

@kyzia551 kyzia551 Awaiting requested review from kyzia551 kyzia551 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sakulstra @codecov-commenter @miguelmtzinf